Add activation flow preference test #17
Conversation
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
2 times, most recently
from
2ae8392
to
9550754
Compare
There was a problem hiding this comment.
Awesome to cover these vetting nudging flows in the behat tests.
IRL you mentioned that the new feature to express the preference via a entitlement attribute was hard to test in this test suite right? OpenConext/Stepup-SelfService#336. It might be possible to collaborate with Pieter and create a new feature in the SSP SP.php test page. And let the SP notify the demo IdP to release a certain attribute if this is requested in the relay state. Just a wild idea that might be usefull in other situations.
There was a problem hiding this comment.
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
from
9550754
to
be0acb7
Compare
Add a test tom for the preferred activation flow query params
pablothedude
force-pushed
the
feature/add-activation-flow-preference-test
branch
from
be0acb7
to
af5a4cd
Compare
| I must be able to manage my second factor tokens | ||
|
|
||
| Scenario: A user registers a Yubikey token in selfservice using RA vetting preference | ||
| Given I receive the following attributes for "joe-a4" from the IdP: |
There was a problem hiding this comment.
Awesome test!!
Suggestion: maybe create a dedicated step definition to indicate you expect the IdP to release no attributes? Perhaps a bit more expressive than the empty table?
Add a test tom for the preferred activation flow query params
OpenConext/Stepup-SelfService#336